GH-3643: Defer MeterRegistry bean dependency #3645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#3643 The `ImportBeanDefinitionRegistrar` register its bean definition in the early phase. It causes a problem with Spring Boot when an explicit `@EnableIntegrationManagement` is declared: the `MeterRegistry` is provided later on via auto-configuration and `MicrometerMetricsCaptor` has no knowledge about `MeterRegistry` at the `ImportBeanDefinitionRegistrar` phase. * Reworks `MicrometerMetricsCaptorRegistrar` to the `MicrometerMetricsCaptorConfiguration` and use special conditional `MicrometerMetricsCaptorImportSelector` for that `@EnableIntegrationManagement`. This way a `MicrometerMetricsCaptor` `@Bean` consults `ObjectProvider<MeterRegistry>` on its creating time and returns `null` if no `MeterRegistry` beans at all.
|
Note: this is some kind of breaking change and with provided workaround in the issue dictate us no back-port policy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3643
The
ImportBeanDefinitionRegistrarregister its bean definition in the early phase.It causes a problem with Spring Boot when an explicit
@EnableIntegrationManagementis declared: the
MeterRegistryis provided later on via auto-configurationand
MicrometerMetricsCaptorhas no knowledge aboutMeterRegistryat theImportBeanDefinitionRegistrarphase.MicrometerMetricsCaptorRegistrarto theMicrometerMetricsCaptorConfigurationand use special conditional
MicrometerMetricsCaptorImportSelectorfor that@EnableIntegrationManagement.This way a
MicrometerMetricsCaptor@BeanconsultsObjectProvider<MeterRegistry>on its creating time and returns
nullif noMeterRegistrybeans at all.